write_excel_csv() and write_excel_csv2() put datetimes in a format…
#1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that is readable again by `readr` on roundtrips.
keesdeschepper
changed the title
write_excel_csv() and write_excel_csv() put datetimes in a format…write_excel_csv() and write_excel_csv2() put datetimes in a format…
|
Just an FYI on why I didn't move on this, I see the point but it would also be a breaking change in some sense, so requires some deliberation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… that is readable again by
readron roundtrips. Beststrftime()format for excel csv datetimes according to https://stackoverflow.com/questions/804118/best-timestamp-format-for-csv-excel#comment57807590_804137 Fixes #1202.